bazci/githubpost: fix pkg calculation from test.xml
#156967
Merged
+71
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the `rules_go` upgrade from cockroachdb#156000, we have accidentally included the test name in the package path. This PR fixes that and fixes the associated test case. Release note: none Epic: none
Member
|
This change is |
rail
approved these changes
Nov 5, 2025
Collaborator
Author
|
bors r=rail |
srosenberg
approved these changes
Nov 5, 2025
craig bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
155564: *: remove remaining references of the meta issue for secondary test tenants r=yuzefovich a=yuzefovich **logictest: reference separate issue for disabling test tenant** **base: remove TODOTestTenantDisabled** All test tenant skips now have specific issues. ***: remove remaining references of the meta issue** Going forward, #76378 will be the meta issue tracking all remaining work for investigating and enabling test tenants across our tests. This commit removes the last explicit mentions of the issue by replacing with specific ones or enabling test tenants on some packages that happened to just work. Epic: CRDB-48945 Release note: None 156593: roachtest/pg_regress: accept recent diff and disable jobs notice r=yuzefovich a=yuzefovich Fixes: #155302. Release note: None 156967: bazci/githubpost: fix `pkg` calculation from `test.xml` r=rail a=rickystewart Since the `rules_go` upgrade from #156000, we have accidentally included the test name in the package path. This PR fixes that and fixes the associated test case. Release note: none Epic: none Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
rules_goupgrade from #156000, we have accidentally included the test name in the package path. This PR fixes that and fixes the associated test case.Release note: none
Epic: none