ui: add store disk write bytes to storage dashboard #156970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
annrpom
requested review from
angles-n-daemons
and removed request for
a team
sumeerbhola
reviewed
Nov 6, 2025
Collaborator
sumeerbhola
left a comment
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @angles-n-daemons)
pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/storage.tsx line 486 at r1 (raw file):
{storeMetrics( { name: "cr.store.storage.disk.write.bytes",
how about adding disk.read.bytes too.
This patch adds a metric for store disk write bytes in the Storage dashboard. Epic: none Release note: None
annrpom
force-pushed
the
storage-dashboard-bytes
branch
2 times, most recently
from
ce86f32 to
1928332
Compare
annrpom
commented
Nov 6, 2025
Contributor
Author
annrpom
left a comment
annrpom
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/storage.tsx line 486 at r1 (raw file):
Previously, sumeerbhola wrote…
how about adding disk.read.bytes too.
ok; done
This patch adds a metric for store disk read bytes in the Storage dashboard. Epic: none Release note: None
annrpom
force-pushed
the
storage-dashboard-bytes
branch
from
1928332 to
8971cd2
Compare
Contributor
Author
|
np; TFTRs! ('-')7 bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 6, 2025
156970: ui: add store disk write bytes to storage dashboard r=annrpom a=annrpom This patch adds a metric for store disk write bytes in the Storage dashboard. Epic: none Informs: https://github.com/cockroachlabs/support/issues/3470 Release note: None <img width="720" height="308" alt="image" src="https://github.com/user-attachments/assets/94629b53-2dc7-4a42-8b68-85ddbd93d006" /> <img width="968" height="411" alt="image" src="https://github.com/user-attachments/assets/e7136191-8df7-4dcf-8150-815661395af1" /> <img width="968" height="407" alt="image" src="https://github.com/user-attachments/assets/3add06df-0f76-48c5-b467-aca2f9742869" /> <img width="975" height="414" alt="image" src="https://github.com/user-attachments/assets/0b6b5812-be09-4def-83e4-96ce57dd36de" /> Co-authored-by: Annie Pompa <annie@cockroachlabs.com>
Contributor
|
Build failed: |
Contributor
Author
|
bors retry |
Contributor
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a metric for store disk write bytes in the Storage dashboard.
Epic: none
Informs: https://github.com/cockroachlabs/support/issues/3470
Release note: None