Skip to content

release-25.4: colexec: fix projections with constant NULL values #156979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
Merged

release-25.4: colexec: fix projections with constant NULL values #156979

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions pkg/sql/colexec/colbuilder/execplan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2828,11 +2828,16 @@ func planProjectionExpr(
resultIdx = len(typs)
// The projection result will be outputted to a new column which is
// appended to the input batch.
// TODO(#127814): We may need to handle the case when the left is DNull.
op, err = colexecprojconst.GetProjectionLConstOperator(
allocator, typs, left.ResolvedType(), outputType, projOp, input,
rightIdx, lConstArg, resultIdx, evalCtx, binOp, cmpExpr, calledOnNullInput,
)
if !calledOnNullInput && (left == tree.DNull || right == tree.DNull) {
// If the left or right is NULL and the operator is not called on
// NULL, simply project NULL.
op = colexecbase.NewConstNullOp(allocator, outputType, input, resultIdx)
} else {
op, err = colexecprojconst.GetProjectionLConstOperator(
allocator, typs, left.ResolvedType(), outputType, projOp, input,
rightIdx, lConstArg, resultIdx, evalCtx, binOp, cmpExpr, calledOnNullInput,
)
}
} else {
var leftIdx int
input, leftIdx, typs, err = planProjectionOperators(
Expand Down
23 changes: 23 additions & 0 deletions pkg/sql/logictest/testdata/logic_test/vectorize
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1343,3 +1343,26 @@ statement ok
RESET vectorize

subtest end

# Regression test for #152771. Gracefully plan operators that cannot handle NULL
# inputs.
statement ok
CREATE TABLE t152771 (i INT)

statement ok
INSERT INTO t152771 VALUES (0)

statement ok
SET plan_cache_mode = force_generic_plan

statement ok
PREPARE p(INT, INT, INT, INT) AS UPDATE t152771 SET i=($1-$2)+($3-$4)

statement ok
EXECUTE p(NULL, 3, 33, NULL)

statement ok
DEALLOCATE p

statement ok
RESET plan_cache_mode