-
Notifications
You must be signed in to change notification settings - Fork 4k
sql: grow stack for DistSQL goroutines #157025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
028fec9 to
9ab1ddc
Compare
This commit makes it so that the main goroutine of Outbox and the vectorized hash router goroutine now start out with the larger stack. Release note: None
9ab1ddc to
f69afc5
Compare
|
These goroutines previously showed up noticeably (like here), but not as much anymore in sysbench (probably because we improved distsql heuristics). I tried to coerce the sysbench microbenchmark to show any impact (using (Initially I also adjusted |
mgartner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up on this!
|
TFTR! bors r+ |
This commit makes it so that the main goroutine of Outbox and the vectorized hash router goroutine now start out with the larger stack.
Addresses: #130663
Epic: None
Release note: None