sql/hints: address minor nits #157041
Merged
sql/hints: address minor nits #157041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note: None
This might be interesting for testing the scenario when the hints cache is disabled (which is allowed by the cluster setting). Release note: None
Member
|
This change is |
yuzefovich
force-pushed
the
hints-nits
branch
from
b03b4d3 to
8d661d4
Compare
Member
Author
|
The last commit seemingly adds a failure under stress that I don't fully understand: Where does the extra DB read come from given that we're not actually executing any queries that would match the fingerprints? |
DrewKimball
approved these changes
Nov 7, 2025
Collaborator
DrewKimball
left a comment
DrewKimball
left a comment
There was a problem hiding this comment.
@DrewKimball reviewed 1 of 1 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Previously, all tests created a separate hints cache that was running side-by-side with the hints cache of the test server. I'm not sure whether there is a reason for it (other than possibly trying to prevent flakes when we start actually using the cache on the main query path), but I don't think it's necessary (e.g. we shouldn't be touching the hints cache for internal queries, and the tests themselves are the only workload that should be affected by the hints cache, and we have full control of that). This commit hooks up all tests to just use the test server's hints cache. One test for verifying that the initial scan populates the existing hints into the cache needed a minor refactor - we now restart the single-node test cluster to simulate the initial scan. Additionally, the LRU test needed hardening if the initial scan is somewhat delayed. What prompted me to look into this is that I was confused why all rangefeed logs (which I enabled temporarily) were being duplicated in tests. It also expands a comment where the behavior wasn't obvious to me. Release note: None
yuzefovich
force-pushed
the
hints-nits
branch
from
8d661d4 to
dd515ac
Compare
yuzefovich
commented
Nov 7, 2025
Member
Author
yuzefovich
left a comment
yuzefovich
left a comment
There was a problem hiding this comment.
That flake was due to initial scan being somewhat delayed (so some of our INSERT INTO system.statement_hints queries happened to perform DB reads).
TFTR!
bors r+
Reviewable status:
Contributor
|
Build failed: |
Member
Author
|
unrelated flake bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few commits that address a few nits I noticed while reviewing the plan hints.
Epic: None