kvserver: avoid starting async raft worker on error #157061
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
tbg
reviewed
Nov 7, 2025
Member
tbg
left a comment
tbg
left a comment
There was a problem hiding this comment.
LGTM except I'm confused about the locking change.
Epic: None Fixes: None Release note: None
cthumuluru-crdb
force-pushed
the
misc-bugfix
branch
from
a3b51b5 to
70bc5eb
Compare
tbg
approved these changes
Nov 10, 2025
Member
tbg
left a comment
tbg
left a comment
There was a problem hiding this comment.
👍🏽 thanks for explaining.
bors r+
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when GetHandle returns an error, we mark the task as done but continue to start raft worker asynchronously.
Epic: None
Fixes: None
Release note: None