util,log: make util.EveryN generic

[stevendanna]

This changes util.EveryN to a generic function and then

• modifies log.EveryN to allow use a crtime.Mono instead of a time.Time.
• updates most callers that were easy to update to use util.EveryMono

We might consider removing the time.Time version of EveryN, but it is still useful in a couple of places.

Epic: none
Release note: None

[cockroach-teamcity]

This change is 

[yuzefovich]

@yuzefovich reviewed 27 of 27 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Abhinav1299, @arjunmahishi, @herkolategan, and @kev-cao)

---

pkg/util/every_n.go line 55 at r1 (raw file):

	var zero T
	e.Lock()
	if e.lastProcessed == zero || now.Sub(e.lastProcessed) >= e.N {

The change to always return true on the first call to ShouldProcess is a behavior change, and although it seems reasonable to me, it'd probably be worth extracting it into a separate commit with explanation for why.

[yuzefovich]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Abhinav1299, @arjunmahishi, @herkolategan, @kev-cao, and @stevendanna)

---

pkg/util/every_n.go line 55 at r1 (raw file):

Previously, yuzefovich (Yahor Yuzefovich) wrote…

The change to always return true on the first call to ShouldProcess is a behavior change, and although it seems reasonable to me, it'd probably be worth extracting it into a separate commit with explanation for why.

Or, actually, it's not a behavior change, right? nvm then

[stevendanna]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @Abhinav1299, @arjunmahishi, @herkolategan, @kev-cao, and @yuzefovich)

---

pkg/util/every_n.go line 55 at r1 (raw file):

Previously, yuzefovich (Yahor Yuzefovich) wrote…

Or, actually, it's not a behavior change, right? nvm then

Right, shouldn't be a behaviour change, at least for all real callers. The code change is a result of the fact that when using a time.Time, now.Sub(e.lastProcessed) would be >= e.N since now was a relatively large value. When using a crtime.Mono, now represents the times since the crtime package's initialisation, which is a very small value.

[stevendanna]

TFRT!

bors r=yuzefovich

[craig]

Build succeeded:

• acceptance
• linux_amd64_build
• examples_orms
• check_generated_code
• lint
• docker_image_amd64
• local_roachtest
• linux_amd64_fips_build
• local_roachtest_fips
• unit_tests