sql/catalog/lease: skip dropped regions when counting leases #158003
Merged
+56
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
countLeasesByRegion now skips regions that were just dropped instead of reporting “failed to count leases”. This was found in the TestMultiRegionTenantRegions test. We did have pre-existing logic to handle missing regions in handleRegionLivenessErrors, but it wasn't handled correctly by all the callers. Resolves: cockroachdb#157122 Release note: none
Member
|
This change is |
fqazi
approved these changes
Nov 18, 2025
Collaborator
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
@spilchen Nice find!
@fqazi reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @spilchen)
Contributor
Author
|
Thanks for the quick review. bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
countLeasesByRegion now skips regions that were just dropped instead of reporting “failed to count leases”. This was found in the TestMultiRegionTenantRegions test. We did have pre-existing logic to handle missing regions in handleRegionLivenessErrors, but it wasn't handled correctly by all the callers.
Resolves: #157122
Release note: none