changefeedccl: respect full_table_name for db-level feeds #158146
Merged
+45
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, DB-level feeds would emit messages with plain table neames, even when full_table_name was specified. Now, we respect this option. Epic: none Fixes: cockroachdb#158145 Release note: None
Member
|
This change is |
asg0451
approved these changes
Nov 20, 2025
Contributor
Author
|
TFTR! bors r=log-head,asg0451 |
craig bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
158055: execstats: Extract AdmissionWorkQueueStats from traces r=alyshanjahani-crl a=alyshanjahani-crl This commit extracts the AdmissionWorkQueueStats that we are recording on traces and adds it to a new field AdmissionWaitTime on the QueryLevelStats object. The total admission wait time is now displayed in explain analyze. A follow up PR will further plumb this through to SQL Stats. Part of: https://cockroachlabs.atlassian.net/browse/CRDB-55925 Release note (sql change): Admission control wait time is now displayed as part of EXPLAIN ANALYZE when non zero. 158146: changefeedccl: respect full_table_name for db-level feeds r=log-head,asg0451 a=aerfrei Previously, DB-level feeds would emit messages with plain table neames, even when full_table_name was specified. Now, we respect this option. Epic: none Fixes: #158145 Release note: None Co-authored-by: alyshanjahani-crl <alyshan@cockroachlabs.com> Co-authored-by: Aerin Freilich <aerin.freilich@cockroachlabs.com>
Contributor
|
Build failed (retrying...): |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, DB-level feeds would emit messages with plain table neames, even when full_table_name was specified. Now, we respect this option.
Epic: none
Fixes: #158145
Release note: None