Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/scripts/docs-prs-reviews.go
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,13 @@ func main() {
if err != nil {
log.Fatalf("error: %v\n", err)
}
fmt.Printf("%v\n", docsPrsMembers)
_, authorIsDocsPrsMember := docsPrsMembers[params.PrAuthor]
if authorIsDocsPrsMember {
fmt.Printf(`User "%s" is a member of docs-prs, so no docs-prs approval required.`, params.PrAuthor)
os.Exit(0)
}
fmt.Printf(`User "%s" is not a member of docs-prs. Checking for docs-prs team approval...\n`, params.PrAuthor)
fmt.Printf(`User "%s" is not a member of docs-prs. Checking for docs-prs team approval...`, params.PrAuthor)

prReviews, err := searchDocsPrReviewers(params.Token, params.PrNumber)
if err != nil {
Expand Down
19 changes: 19 additions & 0 deletions .github/workflows/foo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Foo
on:
pull_request:

jobs:
foo:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@main


- name: Run PR review check
env:
FOO: ${{ secrets.FOO }}
run: |
size=${#FOO}
echo "$size"
12 changes: 7 additions & 5 deletions .github/workflows/pr-reviews.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
name: PR Review
on:
pull_request:
types:
- opened
- reopened
- ready_for_review
# types:
# - opened
# - reopened
# - ready_for_review
pull_request_review:
types:
- submitted
- edited
- dismissed

permissions: read-all

jobs:
pr-review:
Expand All @@ -26,7 +28,7 @@ jobs:

- name: Run PR review check
env:
GITHUB_TOKEN: ${{ secrets.TOKEN_FOR_ORG_MEMBERSHIP }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_AUTHOR: ${{ github.event.pull_request.user.login }}
PR_NUMBER: ${{ github.event.pull_request.number }}
run: go run .github/scripts/docs-prs-reviews.go
2 changes: 2 additions & 0 deletions v23.1/alembic.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ For a detailed tutorial about using Alembic, see [the Alembic documentation site

For information about specific migration tasks, see Alembic's [Cookbook](https://alembic.sqlalchemy.org/en/latest/cookbook.html).

do not merge

## Before you begin

Before you begin the tutorial, [install CockroachDB](install-cockroachdb.html).
Expand Down