Conversation
Contributor
codingconcepts
commented
Nov 26, 2024
codingconcepts
commented
- Update to new cluster setting
- Add groupOfUniqueNames OpenLDAP example
codingconcepts
requested review from
dikshant and
mikeCRL
and removed request for
dikshant
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
Apply the same cluster setting name fix to v25.1 and v25.2 that was already applied to v24.3. Updates server.ldap_authentication.domain_ca to server.ldap_authentication.domain.custom_ca. Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
mikeCRL
approved these changes
May 8, 2026
Contributor
|
@codingconcepts Sorry, lost track of this one! I had otherwise corrected it only for v25.3+, which is probably why we didn't hear further feedback about it. It's now fixed in prior versions, as well. Belated thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.