Skip to content

Conversation

@katmayb
Copy link
Contributor

@katmayb katmayb commented Feb 26, 2025

Fixes DOC-12366

This PR removes sections from the Cloud Storage Authentication page that refer to using the CRL role with Cloud clusters, which is not supported.

@netlify
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 733f3df
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/67dc7f11bbed2100081e429d

@netlify
Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 733f3df
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/67dc7f11eed30d000889fb0f

@katmayb katmayb force-pushed the cloud-storage-auth-advanced-dr branch from b7e8fa4 to 9a0dfc5 Compare February 26, 2025 18:32
@netlify
Copy link

netlify bot commented Feb 26, 2025

Netlify Preview

Name Link
🔨 Latest commit b7e8fa4
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67bf5cb4c48d6f000888394a
😎 Deploy Preview https://deploy-preview-19404--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Feb 26, 2025

Netlify Preview

Name Link
🔨 Latest commit 733f3df
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/67dc7f112759d00008ecd42d
😎 Deploy Preview https://deploy-preview-19404--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@katmayb katmayb marked this pull request as ready for review February 26, 2025 19:24
@katmayb katmayb requested a review from angeladietz February 26, 2025 20:43
@katmayb
Copy link
Contributor Author

katmayb commented Feb 26, 2025

@angeladietz I removed the sections from GCP too, is that correct?

@angeladietz
Copy link
Contributor

I removed the sections from GCP too, is that correct?

Yes I believe its the same for GCP. The removals look okay to me, but i'm wondering if it will break the links to the implicit auth section at the bottom of the page, ie in this section: https://www.cockroachlabs.com/docs/stable/cloud-storage-authentication?#run-the-operation-from-a-cockroachdb-advanced-cluster. We might need some extra details in that section for how to form arn:aws:iam::{AWS account ID}:role/crl-dr-store-user-{cluster ID suffix} (and the same for gcp)

@katmayb
Copy link
Contributor Author

katmayb commented Feb 28, 2025

I removed the sections from GCP too, is that correct?

Yes I believe its the same for GCP. The removals look okay to me, but i'm wondering if it will break the links to the implicit auth section at the bottom of the page, ie in this section: https://www.cockroachlabs.com/docs/stable/cloud-storage-authentication?#run-the-operation-from-a-cockroachdb-advanced-cluster. We might need some extra details in that section for how to form arn:aws:iam::{AWS account ID}:role/crl-dr-store-user-{cluster ID suffix} (and the same for gcp)

That section is part of this flow: https://www.cockroachlabs.com/docs/stable/cloud-storage-authentication?#step-1-set-up-the-identity-role. So, I think it's OK. (It's part of step 3 of the workload identity section.) If there were broken links the build would not have worked as well. In terms of sense though, Step 1 that precedes the section you link to provides details on how to form the arn — but, please let me know if that isn't clear and I'll take another look. Thanks @angeladietz !

@katmayb katmayb requested a review from rmloveland March 19, 2025 17:43
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assume the changes to v25.1 were identical to the prev versions? if so, ✅

@katmayb katmayb force-pushed the cloud-storage-auth-advanced-dr branch from 9a0dfc5 to 733f3df Compare March 20, 2025 20:48
@katmayb katmayb merged commit 4a9ab87 into main Mar 20, 2025
6 checks passed
@katmayb katmayb deleted the cloud-storage-auth-advanced-dr branch March 20, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants