-
Notifications
You must be signed in to change notification settings - Fork 476
Remove the Advanced implicit auth + crl role from cloud storage auth page #19404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Files changed: |
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
b7e8fa4 to
9a0dfc5
Compare
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@angeladietz I removed the sections from GCP too, is that correct? |
Yes I believe its the same for GCP. The removals look okay to me, but i'm wondering if it will break the links to the implicit auth section at the bottom of the page, ie in this section: https://www.cockroachlabs.com/docs/stable/cloud-storage-authentication?#run-the-operation-from-a-cockroachdb-advanced-cluster. We might need some extra details in that section for how to form |
That section is part of this flow: https://www.cockroachlabs.com/docs/stable/cloud-storage-authentication?#step-1-set-up-the-identity-role. So, I think it's OK. (It's part of step 3 of the workload identity section.) If there were broken links the build would not have worked as well. In terms of sense though, Step 1 that precedes the section you link to provides details on how to form the arn — but, please let me know if that isn't clear and I'll take another look. Thanks @angeladietz ! |
rmloveland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assume the changes to v25.1 were identical to the prev versions? if so, ✅
9a0dfc5 to
733f3df
Compare
Fixes DOC-12366
This PR removes sections from the Cloud Storage Authentication page that refer to using the CRL role with Cloud clusters, which is not supported.