make Migration Overview MOLT-centric #19532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
taroface
force-pushed
the
migration-refactor-v3
branch
from
745768a to
778a2d8
Compare
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
❌ Deploy Preview for cockroachdb-docs failed. Why did it fail? →
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
taroface
force-pushed
the
migration-refactor-v3
branch
8 times, most recently
from
e12f37f to
57bbdcf
Compare
Contributor
Author
|
Temporarily removing from review while I do some deeper reorganization (prompted by many broken links). |
taroface
force-pushed
the
migration-refactor-v3
branch
6 times, most recently
from
4140338 to
12b29dd
Compare
src/current/_includes/molt/migration-schema-design-practices.md
Outdated
Show resolved
Hide resolved
taroface
force-pushed
the
migration-refactor-v3
branch
from
f75f2fd to
5001109
Compare
src/current/_includes/molt/migration-schema-design-practices.md
Outdated
Show resolved
Hide resolved
|
Overall changes look good to me with the comments above. |
rohan-joshi
reviewed
May 27, 2025
Contributor
|
To make my local build successful, I made the change in this patch file: It may clear up the deploy-preview error. |
Contributor
florence-crl
left a comment
florence-crl
left a comment
There was a problem hiding this comment.
suggestions for migration-overview.md
Contributor
|
I noticed something was off with the headers on migration-strategy.md: I am continuing my review of migration-strategy.md. |
Contributor
florence-crl
left a comment
florence-crl
left a comment
There was a problem hiding this comment.
suggestions for migration-strategy.md. Most are line edit nits. I will continue reviewing the changes to the other files.
Co-authored-by: Florence Morris <58752716+florence-crl@users.noreply.github.com>
florence-crl
approved these changes
May 29, 2025
Contributor
florence-crl
left a comment
florence-crl
left a comment
There was a problem hiding this comment.
lgtm pending last formatting suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-12110
DOC-12134
DOC-12951
moltsubdirectory, as this is easier to maintain & ties the docs to MOLT tooling, which is already there (link changes are the bulk of the files changed)These changes apply to 23.1-25.2 docs. Please review: