Skip to content

Conversation

@katmayb
Copy link
Contributor

@katmayb katmayb commented May 2, 2025

Fixes DOC-11858

Small addition to the compression option to add webhook sink support.

@netlify
Copy link

netlify bot commented May 2, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 5ab74db
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/681ccd578578cf000802a6f0

@netlify
Copy link

netlify bot commented May 2, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 5ab74db
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/681ccd57daa89700084e0856

@github-actions
Copy link

github-actions bot commented May 2, 2025

Files changed:

@netlify
Copy link

netlify bot commented May 2, 2025

Netlify Preview

Name Link
🔨 Latest commit 5ab74db
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/681ccd562b07160008dd619d
😎 Deploy Preview https://deploy-preview-19582--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@katmayb katmayb requested a review from rharding6373 May 2, 2025 19:41
@rharding6373 rharding6373 requested a review from asg0451 May 5, 2025 20:13
-------|-------|------------
<a name="avro-schema-prefix"></a>`avro_schema_prefix` | Schema prefix name | Provide a namespace for the schema of a table in addition to the default, the table name. This allows multiple databases or clusters to share the same schema registry when the same table name is present in multiple databases.<br><br>Example: `CREATE CHANGEFEED FOR foo WITH format=avro, confluent_schema_registry='registry_url', avro_schema_prefix='super'` will register subjects as `superfoo-key` and `superfoo-value` with the namespace `super`.
<a name="compression"></a>`compression` | `gzip`, `zstd` | Compress changefeed data files written to a [cloud storage sink]({% link {{ page.version.version }}/changefeed-sinks.md %}#cloud-storage-sink). For compression options when using a Kafka sink, see [Kafka sink configuration]({% link {{ page.version.version }}/changefeed-sinks.md %}#kafka-sink-configuration).
<a name="compression"></a>`compression` | `gzip`, `zstd` | Compress changefeed data files written to:<ul><li>[Cloud storage sinks]({% link {{ page.version.version }}/changefeed-sinks.md %}#webhook-sink)</li><li><span class="version-tag">New in v25.2:</span>[Webhook sinks]({% link {{ page.version.version }}/changefeed-sinks.md %}#cloud-storage-sink)</li></ul>. For compression options when using a Kafka sink, see [Kafka sink configuration]({% link {{ page.version.version }}/changefeed-sinks.md %}#kafka-sink-configuration).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links are reversed (webhook sink link is on cloud storage sink text and vice versa)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh whoops! Thanks for catching that :)

@katmayb katmayb requested a review from rmloveland May 7, 2025 19:28
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katmayb katmayb force-pushed the webhook-compression-option branch from b9fe098 to 5ab74db Compare May 8, 2025 15:27
@katmayb katmayb merged commit c4b6e82 into main May 8, 2025
6 checks passed
@katmayb katmayb deleted the webhook-compression-option branch May 8, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants