Skip to content

Conversation

@taroface
Copy link
Contributor

@taroface taroface commented May 9, 2025

@taroface taroface requested review from andy-kimball and dikshant May 9, 2025 05:16
@netlify
Copy link

netlify bot commented May 9, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 440d094
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/6821f9fd6a7501000826af73

@netlify
Copy link

netlify bot commented May 9, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 440d094
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/6821f9fd19f7f9000840b3df

@github-actions
Copy link

github-actions bot commented May 9, 2025

@taroface taroface requested a review from DrewKimball May 9, 2025 05:16
@netlify
Copy link

netlify bot commented May 9, 2025

Netlify Preview

Name Link
🔨 Latest commit 440d094
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6821f9fd355cd9000892dcb4
😎 Deploy Preview https://deploy-preview-19595--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@dikshant dikshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

@taroface
Copy link
Contributor Author

taroface commented May 9, 2025

@dikshant @andy-kimball TFTRs! I've incorporated your comments.

@taroface taroface requested a review from dikshant May 9, 2025 17:01
@taroface taroface requested a review from DrewKimball May 9, 2025 18:40
Copy link

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice work!

@taroface taroface requested a review from florence-crl May 9, 2025 19:02
Copy link

@dikshant dikshant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work! 🚀

Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending questions/suggestions
very informative

- {% include {{ page.version.version }}/sql/vector-batch-inserts.md %}
- Creating a vector index through a backfill disables mutations ([`INSERT`]({% link {{ page.version.version }}/insert.md %}), [`UPSERT`]({% link {{ page.version.version }}/upsert.md %}), [`UPDATE`]({% link {{ page.version.version }}/update.md %}), [`DELETE`]({% link {{ page.version.version }}/delete.md %})) on the table. [#144443](https://github.com/cockroachdb/cockroach/issues/144443)
- `IMPORT INTO` is not supported on tables with vector indexes. You can import the vectors first and create the index after import is complete. [#145227](https://github.com/cockroachdb/cockroach/issues/145227)
- Only L2 distance (`<->`) searches are accelerated. [#144016](https://github.com/cockroachdb/cockroach/issues/144016)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by "accelerated"? Should "accelerated" be "supported"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accelerated means that the index makes these types of searches faster. This is the correct term because VECTOR supports more operators than L2, but this is the only one that a vector index currently benefits.

taroface and others added 3 commits May 12, 2025 09:26
Co-authored-by: Florence Morris <58752716+florence-crl@users.noreply.github.com>
@taroface taroface enabled auto-merge (squash) May 12, 2025 13:39
@taroface taroface merged commit ab91500 into main May 12, 2025
7 checks passed
@taroface taroface deleted the vector-indexes branch May 12, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants