-
Notifications
You must be signed in to change notification settings - Fork 479
Update temp tables docs re: perf caveats vs CTEs #20221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
rafiss
approved these changes
Aug 27, 2025
taroface
approved these changes
Aug 28, 2025
Contributor
taroface
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left some optional suggestions. I don't feel that strongly about spelling out "temp" everywhere, so your call.
Contributor
Author
|
TFTRs! Backporting to supported versions v24.1+ and merging ... |
Fixes DOC-13355 Summary of changes: - Update temp tables docs with a 'perf considerations' section that warns users about possible perf impacts incl. schema change GC risk, recommends CTEs - Update temp table docs 'examples' section to mention CTEs as an alternative - Update CTE docs to mention that they can be used instead of temp tables - Update the feature availability page re: temp tables to add more info re: schema change GC risk NB. Applied changes to supported versions v24.1+
d7e60a3 to
bc1c85b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DOC-13355
Summary of changes:
Update temp tables docs with a 'perf considerations' section that warns users about possible perf impacts incl. schema change GC risk, recommends CTEs
Update temp table docs 'examples' section to mention CTEs as an alternative
Update CTE docs to mention that they can be used instead of temp tables
Update the feature availability page re: temp tables to add more info
re: schema change GC risk