Skip to content

Conversation

@florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Oct 3, 2025

Fixes DOC-14622 DOC-14631 DOC-14634 DOC-14650 DOC-14818 DOC-14929

  • In session-vars.md, added row for allow_unsafe_internals.
  • In crdb-internal.md, added a section for Access control.
  • In functions-and-operators.md, removed reference to a crdb_internal built-in function.
  • In logging-use-cases, added a section for Example: Unsafe internals.
  • In system-catalogs.md, added description of allow_unsafe_internals with a warning.
  • In lease-preference-system-database.md, added clarification note.

Rendered preview

In crdb-internal.md, added a section for Access control.

In functions-and-operators.md, removed reference to a crdb_internal built-in function.

In logging-use-cases, added a section for Example: Unsafe internals.

In system-catalogs.md, modified by codex.
@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 51a934f
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/690522d5c2734e0008785804

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

@netlify
Copy link

netlify bot commented Oct 3, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 51a934f
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/690522d5c172c200081e1edb

@netlify
Copy link

netlify bot commented Oct 3, 2025

Netlify Preview

Name Link
🔨 Latest commit 51a934f
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/690522d532cd25000825578c
😎 Deploy Preview https://deploy-preview-20486--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@florence-crl florence-crl changed the title DOC-14622: Product Change- PR #151362 - sql: gate system database behind session variable v25.4 changes related to allow_unsafe_internals session variable Oct 6, 2025
Copy link

@angles-n-daemons angles-n-daemons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple quick comments, thanks for this!

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR

Copy link

@kevin-v-ngo kevin-v-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few nits.

Can we also call out that if users need to information that is not available in a production-supported manner in information_schema that they should work with their account team and/or create a support ticket? Not exactly sure where this should be but some place easily discoverable and reference able.

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added clarification note to Schema changes in multi-region clusters example.

TFTR

Copy link

@angles-n-daemons angles-n-daemons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

Copy link
Contributor

@peachdawnleach peachdawnleach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few small comments

Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR

Copy link

@kevin-v-ngo kevin-v-ngo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@florence-crl florence-crl merged commit 775e231 into main Oct 31, 2025
5 checks passed
@florence-crl florence-crl deleted the DOC-14622 branch October 31, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants