-
Notifications
You must be signed in to change notification settings - Fork 477
v25.4 changes related to allow_unsafe_internals session variable #20486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In crdb-internal.md, added a section for Access control. In functions-and-operators.md, removed reference to a crdb_internal built-in function. In logging-use-cases, added a section for Example: Unsafe internals. In system-catalogs.md, modified by codex.
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed:
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple quick comments, thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! A few nits.
Can we also call out that if users need to information that is not available in a production-supported manner in information_schema that they should work with their account team and/or create a support ticket? Not exactly sure where this should be but some place easily discoverable and reference able.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added clarification note to Schema changes in multi-region clusters example.
TFTR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few small comments
src/current/_includes/v25.4/performance/lease-preference-system-database.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR
src/current/_includes/v25.4/performance/lease-preference-system-database.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes DOC-14622 DOC-14631 DOC-14634 DOC-14650 DOC-14818 DOC-14929
Rendered preview