Skip to content

Conversation

@rmloveland
Copy link
Contributor

Fixes DOC-14041

@netlify
Copy link

netlify bot commented Oct 28, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 0ad788e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/691f714e374a470008c197b6

@rmloveland rmloveland requested a review from bghal October 28, 2025 19:13
@netlify
Copy link

netlify bot commented Oct 28, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 0ad788e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/691f714e5c915300070a4811

@rmloveland
Copy link
Contributor Author

hi @bghal figured you would be the right reviewer for these docs since you wrote cockroachdb/cockroach#148290

@netlify
Copy link

netlify bot commented Oct 28, 2025

Netlify Preview

Name Link
🔨 Latest commit 0ad788e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/691f714e3a72cd0007bec9ff
😎 Deploy Preview https://deploy-preview-20829--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending suggestions.

Also, please modify /v25.4/understand-hotspots.md by changing the hash from #cache-sequence-values-in-memory to #cache-sequence-values-in-memory-per-node

@rmloveland rmloveland force-pushed the 20251028-DOC-14041-node-level-sequence-caching branch from 394a136 to 3c6a455 Compare November 20, 2025 18:06
@rmloveland
Copy link
Contributor Author

LGTM pending suggestions.

Also, please modify /v25.4/understand-hotspots.md by changing the hash from #cache-sequence-values-in-memory to #cache-sequence-values-in-memory-per-node

Thanks Florence! Also fixed the link in 'Understand Hotspots'

PS backported these changes to v25.3 as well since that's the version label on the PR: cockroachdb/cockroach#148290

@rmloveland rmloveland enabled auto-merge (squash) November 20, 2025 18:08
Fixes DOC-14041

Changes ported to: v25.3, v25.4
@rmloveland rmloveland force-pushed the 20251028-DOC-14041-node-level-sequence-caching branch from a89c2b6 to ecdb323 Compare November 20, 2025 19:51
@rmloveland rmloveland disabled auto-merge November 20, 2025 19:51
@rmloveland rmloveland merged commit 4ec16b5 into main Nov 20, 2025
5 checks passed
@rmloveland rmloveland deleted the 20251028-DOC-14041-node-level-sequence-caching branch November 20, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants