Improve block cache description, update default #20874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Contributor
Author
|
@jbowens i will make sure the content that is backported does not backport the 256 MiB default value for |
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
florence-crl
approved these changes
Nov 18, 2025
Contributor
florence-crl
left a comment
florence-crl
left a comment
There was a problem hiding this comment.
lgtm pending non-blocking suggestions
Contributor
Author
|
Thanks for the reviews! Backporting the cache info to all supported versions v24.1+ before merging (modulo the 256 MiB default which only applies to v25.4) |
rmloveland
force-pushed
the
20251029-DOC-15012-storage-engine-block-cache
branch
from
9e0719f to
619ebd3
Compare
rmloveland
force-pushed
the
20251029-DOC-15012-storage-engine-block-cache
branch
from
8554a33 to
1a3ed4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
NB. Updated description of block cache is ported to all supported versions, while update to block cache size default only applies to v25.4.