Skip to content

v26.2 previews of faster restore, improved show backups; syntax updates/removals#23215

Merged
mikeCRL merged 17 commits into
mainfrom
DOC-16503_faster-show-backups
Apr 24, 2026
Merged

v26.2 previews of faster restore, improved show backups; syntax updates/removals#23215
mikeCRL merged 17 commits into
mainfrom
DOC-16503_faster-show-backups

Conversation

@mikeCRL
Copy link
Copy Markdown
Contributor

@mikeCRL mikeCRL commented Apr 23, 2026

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 23, 2026

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 387dcad
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/69ebdd2aeef1c80008993708

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 23, 2026

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 387dcad
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/69ebdd2acc24940007af9842

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 23, 2026

Netlify Preview

Name Link
🔨 Latest commit 387dcad
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/69ebdd2a537e870008b6443f
😎 Deploy Preview https://deploy-preview-23215--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

@mikeCRL mikeCRL force-pushed the DOC-16503_faster-show-backups branch 2 times, most recently from ecf873e to ee64899 Compare April 24, 2026 13:19
- Backup IDs with efficient querying (use_backups_with_ids session variable, NEWER THAN/OLDER THAN filtering)
- Faster restore with WITH EXPERIMENTAL COPY option
- Backup compactions for extended backup chains
- Remove incremental_location option (breaking change)

Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@mikeCRL mikeCRL force-pushed the DOC-16503_faster-show-backups branch from 8e091fe to 7a54c9f Compare April 24, 2026 13:52
mikeCRL and others added 2 commits April 24, 2026 10:01
This session variable is already in main via PR #23200 and should not appear in this PR's diff.

Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@mikeCRL mikeCRL changed the title v26.2 previews of faster restore, improved show backups; syntax deprecations/removals [DOC-16710] [DOC-16709] [DOC-16503] v26.2 previews of faster restore, improved show backups; syntax deprecations/removals Apr 24, 2026
@mikeCRL mikeCRL marked this pull request as ready for review April 24, 2026 14:04
@mikeCRL mikeCRL requested a review from kev-cao April 24, 2026 14:04
mikeCRL added 2 commits April 24, 2026 10:13
- Remove broken references to deleted incremental_location section
- Replace cluster settings anchor links with plain code text (backup.compaction.threshold, backup.index.read.enabled)
Comment thread src/current/_includes/v26.2/misc/session-vars.md
Comment thread src/current/v26.2/backup.md Outdated
Comment thread src/current/v26.2/backup.md Outdated
Comment thread src/current/v26.2/backup.md Outdated
Comment thread src/current/v26.2/backup.md Outdated

### Combine with faster restore

You can combine backup IDs with the `WITH EXPERIMENTAL COPY` option for maximum performance:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maximum performance

Image

Comment thread src/current/v26.2/show-backup.md Outdated
Comment thread src/current/v26.2/show-backup.md
Comment thread src/current/v26.2/show-backup.md Outdated
Comment thread src/current/v26.2/show-backup.md Outdated
@mikeCRL mikeCRL requested a review from kev-cao April 24, 2026 16:44
Copy link
Copy Markdown

@kev-cao kev-cao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! The only required changes right now are fixing the backup IDs to be proper backup IDs instead of timestamps, and removing the revision_start_time column when WITH REVISION START TIME isn't specified.

I went through some of our test backups and found this that you could use for our examples:

         id        |      backup_time       |  revision_start_time
-------------------+------------------------+-------------------------
  Wnfqrp0BAAD4tw8= | 2026-04-21 07:21:35+00 | 2026-04-21 07:20:22+00
  clvprp0BAADQmww= | 2026-04-21 07:20:22+00 | 2026-04-21 07:16:26+00
  osDlrp0B         | 2026-04-21 07:16:26+00 | 1970-01-01 00:00:00+00

Comment thread src/current/v26.2/backup.md Outdated

The threshold is the backup chain length at which compaction triggers:
- `0`: Disabled (default)
- `4`: Compaction occurs when chain reaches length 4 (1 full + 3 incrementals)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should have stronger wording about setting it to 4. If a customer reads this, they may be tempted to start setting it to what they think would work for them. @msbutler what do you think?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. At first glance this read to me that 4 is the minimum value but it can be set higher as desired. If we want to keep the recommended value at 4, that should be emphasized.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msbutler @kev-cao Do you want to just be explicit here and elsewhere that 'higher values are not recommended' and try to drop an earlier mention that this is a 'configurable' number, just to de-emphazie that point, without actually implying everywhere that it's not configurable? Maybe that's the balance?

LMK and I'll try to implement. Also wouldn't mind merging and iterating, if that is better, to help our team get things sorted for the release quickly.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think having an explicit statement is fine

mikeCRL and others added 4 commits April 24, 2026 13:05
Replace timestamp-based IDs with real backup IDs from engineer's sample data:
- Wnfqrp0BAAD4tw8= (newest)
- clvprp0BAADQmww= (middle)
- osDlrp0B (oldest)

Updated all SHOW BACKUPS and RESTORE examples in show-backup.md and restore.md to use proper backup ID format instead of timestamps like '2026-04-16T14:23:55.335570Z'.

Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@mikeCRL
Copy link
Copy Markdown
Contributor Author

mikeCRL commented Apr 24, 2026

Overall looks good to me! The only required changes right now are fixing the backup IDs to be proper backup IDs instead of timestamps, and removing the revision_start_time column when WITH REVISION START TIME isn't specified.

I went through some of our test backups and found this that you could use for our examples:

         id        |      backup_time       |  revision_start_time
-------------------+------------------------+-------------------------
  Wnfqrp0BAAD4tw8= | 2026-04-21 07:21:35+00 | 2026-04-21 07:20:22+00
  clvprp0BAADQmww= | 2026-04-21 07:20:22+00 | 2026-04-21 07:16:26+00
  osDlrp0B         | 2026-04-21 07:16:26+00 | 1970-01-01 00:00:00+00

@kev-cao FIxed! PTAL. I think all the necessary items are now resolved.

@mikeCRL mikeCRL requested a review from kev-cao April 24, 2026 17:33
@mikeCRL mikeCRL changed the title v26.2 previews of faster restore, improved show backups; syntax deprecations/removals v26.2 previews of faster restore, improved show backups; syntax updates/removals Apr 24, 2026
Copy link
Copy Markdown
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments and suggestions

Comment thread src/current/v26.2/backup-and-restore-overview.md Outdated
Comment thread src/current/v26.2/backup.md Outdated

The threshold is the backup chain length at which compaction triggers:
- `0`: Disabled (default)
- `4`: Compaction occurs when chain reaches length 4 (1 full + 3 incrementals)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. At first glance this read to me that 4 is the minimum value but it can be set higher as desired. If we want to keep the recommended value at 4, that should be emphasized.

Comment thread src/current/v26.2/backup.md
Comment thread src/current/v26.2/backup.md Outdated

| Setting | Description | Default |
|---------|-------------|---------|
| `backup.compaction.threshold` | Backup chain length at which compaction triggers. `0` disables; minimum `4`. | `0` |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `backup.compaction.threshold` | Backup chain length at which compaction triggers. `0` disables; minimum `4`. | `0` |
| `backup.compaction.threshold` | Backup chain length at which compaction triggers. `0` disables; minimum and recommended value of `4`. | `0` |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a suggestion - see above discussion

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same feedback applies to other files if eng determines this is the suggested approach

Comment thread src/current/v26.2/restore.md Outdated

### Prerequisites

To run faster restores, [backup compactions]({% link {{ page.version.version }}/backup.md %}#backup-compactions) must be enabled on the backup you are restoring from. To enable compactions, set the `backup.compaction.threshold` cluster setting to `4` or higher before creating your backups.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording makes it sound like "faster restores" is a proper noun/feature name, rather than descriptive. Suggest "To optimize restore performance" as a more descriptive alternative

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhlodin Since this restore method is distinct, it’s likely to read like a feature name, even while we intentionally avoid fully treating it like one. Eng/PM aligned on “faster restores,” and I’d prefer to stick with that to avoid it being misread as just a faster version of the traditional approach, which it isn’t. The Preview status also helps signal that it’s something different.

This is a temporary phase anyway; it’ll eventually become the default (details TBD). For now, we clarify that it refers to restores using WITH EXPERIMENTAL COPY, though that specific syntax likely won’t always be required.

The only alternative I’ve considered is a more-specific “Faster restores using WITH EXPERIMENTAL COPY,” but it’s a bit clunky, so I leaned on context instead. Open to other ideas, but hopefully that context helps explain the tradeoffs and the choice thus far?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. If eng/PM aligned on the name already then I won't push back more now

Comment thread src/current/v26.2/restore.md
@mikeCRL mikeCRL requested a review from jhlodin April 24, 2026 19:15
Copy link
Copy Markdown

@kev-cao kev-cao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread src/current/v26.2/backup.md Outdated
Copy link
Copy Markdown

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work on this!

Comment thread src/current/v26.2/backup.md Outdated
Comment thread src/current/v26.2/restore.md Outdated

### Prerequisites

To run faster restores, [backup compactions]({% link {{ page.version.version }}/backup.md %}#backup-compactions) must be enabled on the backup you are restoring from. To enable compactions, set the `backup.compaction.threshold` cluster setting to `4` or higher before creating your backups.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we simply say; set the value to 4?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this before. Refined.

@mikeCRL mikeCRL requested a review from msbutler April 24, 2026 20:36
Comment thread src/current/v26.2/backup.md Outdated

| Setting | Description | Default |
|---------|-------------|---------|
| `backup.compaction.threshold` | Backup chain length at which compaction triggers. `0` disables. `4` is the only recommended value for compaction. | `0` |
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do need to keep backup.compaction.threshold cluster setting change doc, just not backup.index.read.enabled

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msbutler I dropped the table because we thoroughly covered backup.compaction.threshold nearby with the same details, so the section/table no longer seemed necessary. WDYT?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, then its fine to drop the table. ty!

@mikeCRL mikeCRL requested a review from msbutler April 24, 2026 20:45
Copy link
Copy Markdown

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this so quickly!

Copy link
Copy Markdown
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikeCRL mikeCRL enabled auto-merge (squash) April 24, 2026 21:14
@mikeCRL mikeCRL merged commit 1c9933a into main Apr 24, 2026
7 checks passed
@mikeCRL mikeCRL deleted the DOC-16503_faster-show-backups branch April 24, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants