Skip to content

document PCR read from standby limitation in all affected versions#23255

Merged
taroface merged 4 commits into
mainfrom
pcr-known-limitation
May 13, 2026
Merged

document PCR read from standby limitation in all affected versions#23255
taroface merged 4 commits into
mainfrom
pcr-known-limitation

Conversation

@taroface
Copy link
Copy Markdown
Contributor

@taroface taroface commented May 5, 2026

A known limitation for PCR was added to the 26.2 GA release notes. However, the limitation affects all versions that contain the PCR read-from-standby feature, and had not been documented. This PR adds the known limitation where applicable.

@taroface taroface requested a review from msbutler May 5, 2026 20:46
@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 7ea677e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/6a04ecf6bae99200087b6269

@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 7ea677e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/6a04ecf618a8cd00083fb3d9

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Files changed:

@msbutler
Copy link
Copy Markdown

msbutler commented May 5, 2026

@taroface we landed a fix cockroachdb/cockroach#169351 that will likely address this known limitation on 26.2.1, 26.1.5, 25.4.11. Given this, should we still document this known limitation?

@netlify
Copy link
Copy Markdown

netlify Bot commented May 5, 2026

Netlify Preview

Name Link
🔨 Latest commit 7ea677e
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/6a04ecf60bad3d00086c2e89
😎 Deploy Preview https://deploy-preview-23255--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@taroface
Copy link
Copy Markdown
Contributor Author

taroface commented May 7, 2026

@taroface we landed a fix cockroachdb/cockroach#169351 that will likely address this known limitation on 26.2.1, 26.1.5, 25.4.11. Given this, should we still document this known limitation?

@msbutler I see that has merged -- is the known limitation definitely removed from those versions?

And what's our intention for 25.2 and 24.3?

@msbutler
Copy link
Copy Markdown

msbutler commented May 8, 2026

@taroface I think the known limitation has been removed for 26.2-25.4. I dont think we intend to backport the fixes to 24.3 and 25.2, so the known limitation still applies to them.

taroface and others added 2 commits May 13, 2026 10:42
The known limitation about reader virtual cluster startup stalling
has been fixed in v26.2, v26.1, and v25.4 via backports. The
limitation still applies to v24.3 and v25.2, as there are no plans
to backport the fix to those versions.

Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@taroface taroface force-pushed the pcr-known-limitation branch from d69edca to 1ba6aa1 Compare May 13, 2026 14:46
@taroface
Copy link
Copy Markdown
Contributor Author

@taroface I think the known limitation has been removed for 26.2-25.4. I dont think we intend to backport the fixes to 24.3 and 25.2, so the known limitation still applies to them.

@msbutler Noted - for 26.2, is the fix going into 26.2.1? Meaning that I should leave the known limitation documented for the 26.2.0 GA notes.

@msbutler
Copy link
Copy Markdown

is the fix going into 26.2.1?
correct! sounds good to keep the known limitation for .0

@taroface
Copy link
Copy Markdown
Contributor Author

@msbutler Let me know if you can stamp this PR - it's just 25.2 and 24.3 (and 26.2.0) with the known limitation now!

Copy link
Copy Markdown

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@taroface taroface requested a review from a team May 13, 2026 18:29
Copy link
Copy Markdown
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ALTER VIRTUAL CLUSTER {reader_vc} START SERVICE SHARED;
~~~

[#169078](https://github.com/cockroachdb/cockroach/issues/169078)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this and the other github link, we are in process of removing such links via DOC-17040

otherwise LGTM!

taroface and others added 2 commits May 13, 2026 17:27
Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
@taroface taroface enabled auto-merge (squash) May 13, 2026 21:28
@taroface taroface merged commit a8590af into main May 13, 2026
8 checks passed
@taroface taroface deleted the pcr-known-limitation branch May 13, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants