Skip branch existence checks for archived doc versions#23370
Merged
Conversation
Fixes #23175. The nightly branch existence workflow fails for v1.0, v1.1, v2.0, v2.1, v19.1, and v19.2 because their branches no longer exist in cockroachdb/generated-diagrams. Rather than modifying versions.csv, update the validation script to skip versions that have been archived from the site (i.e., have no docs folder under src/current/). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
mohini-crl
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/current/)cockroachdb/generated-diagrams, but theircrdb_branch_nameentries inversions.csvare still valid historical data — so the script now skips them rather than requiring data changesTest plan
python3 .github/scripts/validate_branch_existence.py --self-testpasses (2 new test cases added)versions.csvpasses — archived versions printSKIP (archived), active versions still checked normally🤖 Generated with Claude Code