markers: avoid panic on non-comparable structs #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an error struct implements `error` by value and the struct is incomparable, the previous implementation of `Is` would panic. This patch fixes it. Inspired from https://go-review.googlesource.com/c/go/+/175260
yuzefovich
approved these changes
Sep 20, 2022
Member
yuzefovich
left a comment
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nvanbenschoten)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while investigating cockroachdb/cockroach#87555
If an error struct implements
errorby value and the struct is incomparable, the previous implementation ofIswould panic. This patch fixes it.Inspired from https://go-review.googlesource.com/c/go/+/175260
This change is