feat: 128 bit UUIDs for client & device auth IDs#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added 128 bit client-generated IDs for user authentication and device authentication identifiers.
RAND_bytesfrom OpenSSL is used for the random generation. The Protocol header and envelope data now serialize/deserialize 128 bit IDs instead of the temporary 32 bit integer IDs. The routing hashmap infaithdnow keys by the 128 bit structure instead of a simple uint32_t.client_id_tanddevice_id_tare now typedefed as:Testing
Describe how you tested this change.
scripts/check.shpasses locally