fix the device crach appeared when the device fallback is performed #11818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check ReportThis pull request does not change any public interfaces ! |
dumganhar
approved these changes
Jul 1, 2022
dumganhar
reviewed
Jul 1, 2022
| }); | ||
| if (!_mainMessageQueue) { | ||
| if(_actor) { | ||
| _actor->destroy(); |
Contributor
There was a problem hiding this comment.
Does it need to set _actor to nullptr?
Contributor
Author
There was a problem hiding this comment.
No need. The actor is intrusive and can be deleted automatically.
Contributor
There was a problem hiding this comment.
It is not IntrusivePtr now. It is a raw pointer. It is deleted in DeviceAgent destructor.
|
@yiwenxue, Please check the result of
|
|
@yiwenxue, Please check the result of
|
|
@cocos-robot run test cases |
|
@yiwenxue, Please check the result of
|
|
@yiwenxue, Please check the result of
|
|
@yiwenxue, Please check the result of
|
|
@yiwenxue, Please check the result of
|
star-e
approved these changes
Jul 4, 2022
|
@yiwenxue, Please check the result of
|
|
@yiwenxue, Please check the result of
|
dumganhar
approved these changes
Jul 4, 2022
minggo
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #https://github.com/cocos/3d-tasks/issues/12474#issue-1255571596
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: