feat: support general WASM module in engine #14974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pal/wasm
# Conflicts: # pal/system-info/web/system-info.ts # Conflicts: # pal/system-info/web/system-info.ts # Conflicts: # pal/system-info/web/system-info.ts
update
minggo
reviewed
May 6, 2023
minggo
reviewed
May 6, 2023
pal/system-info/web/system-info.ts
Outdated
| // refer https://stackoverflow.com/questions/47879864/how-can-i-check-if-a-browser-supports-webassembly | ||
| const supportWasm = (() => { | ||
| // iOS 15.4 has some wasm memory issue, can not use wasm for bullet | ||
| const isiOS15_4 = (this.os === OS.IOS || this.os === OS.OSX) && /(OS 15_4)|(Version\/15.4)/.test(window.navigator.userAgent); |
Contributor
Author
There was a problem hiding this comment.
it's a history bug fix, it seems that on safari, there is some memory issue
Contributor
There was a problem hiding this comment.
But the variable name is isiOS15_4 .
Contributor
Author
There was a problem hiding this comment.
yes, it means on safari iOS15.4
minggo
reviewed
May 6, 2023
minggo
reviewed
May 6, 2023
minggo
reviewed
May 6, 2023
pal/system-info/web/system-info.ts
Outdated
| // iOS 15.4 has some wasm memory issue, can not use wasm for bullet | ||
| const isiOS15_4 = (this.os === OS.IOS || this.os === OS.OSX) && /(OS 15_4)|(Version\/15.4)/.test(window.navigator.userAgent); | ||
| if (isiOS15_4) { | ||
| // safari iOS 15.4 has some wasm memory issue, can not use wasm for bullet |
Contributor
There was a problem hiding this comment.
I think should modify the comment too? As not only has issue on iOS.
minggo
approved these changes
May 6, 2023
hana-alice
approved these changes
May 6, 2023
lealzhan
approved these changes
May 6, 2023
yiwenxue
approved these changes
May 6, 2023
PPpro
commented
May 6, 2023
* add physx wasm * update physx wasm instantiate. * update, rename, etc.
shrinktofit
reviewed
May 8, 2023
shrinktofit
reviewed
May 8, 2023
shrinktofit
reviewed
May 8, 2023
shrinktofit
approved these changes
May 8, 2023
|
@PPpro ❗ There was an error during the execution of the tasks. Please check the logs for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: https://github.com/cocos/3d-tasks/issues/6330
Changelog
pal/wasmmodule exportingisntantiateWASMinterfacesys.hasFeature(sys.Feature.WASM)queryWASM_SUPPORT_MODEconstant ininternal:constantsmodulebulletphysxandwebgpuRelative PR
Tested Platform
Tested Module
WASM docs
https://github.com/cocos/3d-tasks/blob/master/design-docs/scripting/engine-wasm-module.md
Continuous Integration
This pull request:
Compatibility Check
This pull request: