Skip to content

Conversation

@0xytoken
Copy link

As discussed with @ekoleda-codaio in the forum, there is some misunderstanding about how featuredProperties can and can't be used and the workarounds existing for these cases. This additional description should clear up some of that - it would've for me 👍

@0xytoken 0xytoken requested a review from a team as a code owner May 31, 2022 15:20
Copy link
Collaborator

@jonathan-codaio jonathan-codaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

You'll need to generate the downstream documentation files by running make build and then committing those. As a one-time setup step (and then periodically if dependencies change) you'll need to run make bootstrap first.

But, we've never had people outside of Coda try this so you might encounter some errors in those commands. If you do, just shout back and we can build and commit the generated files for you.

Copy link
Contributor

@ekoleda-codaio ekoleda-codaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

schema.ts Outdated
* columns for any other properties, as desired.
* columns for any other properties, as desired. All featured properties need to be top-level.
* If you can't or don't want to change the received data format, consider changing the
* received object after fetching and before returning and assigning it to the scheme.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"scheme" => "schema".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated it in commit d3cf1be 👍

@ekoleda-codaio ekoleda-codaio added the documentation Related to the documentation in /docs. label May 31, 2022
@jonathan-codaio
Copy link
Collaborator

Whether because this is a fork or because it's a third-party author, it looks like our continuous integration verification isn't running on this PR, plus it needs a make build. So for expediency I just recreated it and did the build step:

#2036

@0xytoken
Copy link
Author

0xytoken commented Jun 2, 2022

Awesome! Thanks!

@0xytoken 0xytoken closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to the documentation in /docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants