breaking: Simplify SBOM result class [TAROT-3624]#103
Merged
Conversation
Codacy's Analysis Summary0 new issue (≤ 1 medium issue) Review Pull Request in Codacy →
|
fd4a59e to
23a0688
Compare
lorandszakacs
approved these changes
Feb 10, 2026
lolgab
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this simplification is to be independent of the SBOM format itself at this point.
Downstream consumers decide if they want to unmarshal the SBOM (and how) based on it's format and spec version.
No scala tools are producing SBOMs, so none need to actually change. No scala tool is even using a version of this library that includes SBOMs.
However, golang tools can already produce SBOMs, so the golang seed needs to be updated.
codacy-trivywill also need to be updated to match the new format.There will be a point when deploying new versions for worker and
codacy-trivywhen SBOM parsing will be broken but that is OK because: