feat: Integrate with CLI v2 CY-7445 #43
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
inesgomas
force-pushed
the
setup-cli-v2-CY-7445
branch
from
b0a6a9f to
36417ec
Compare
inesgomas
force-pushed
the
setup-cli-v2-CY-7445
branch
from
1e812e4 to
0eef37a
Compare
* added temp file analysis and sarif processing, still in progress * refactor diagnostics to support both API and CLI * add analysis of unsaved files * local analysis working with latest version of cli v2
| } | ||
|
|
||
| const documentLines = document.getText().split('\n') | ||
| private updateApiISsuesPositions(document: vscode.TextDocument) { |
There was a problem hiding this comment.
There is a typo in the method name 'updateApiISsuesPositions'. It should be spelled 'updateApiIssuesPositions' to improve clarity.
| private updateApiISsuesPositions(document: vscode.TextDocument) { | |
| private updateApiIssuesPositions(document: vscode.TextDocument) { |
| GitProvider.instance?.onDidChangeTextDocument((e) => { | ||
| this.updatePositions(e.document) | ||
| GitProvider.instance?.onDidChangeTextDocument(async (e) => { | ||
| // avoid if the ddocument is a .git file |
There was a problem hiding this comment.
The comment contains a typo ('ddocument'); it should be corrected to 'document'.
| // avoid if the ddocument is a .git file | |
| // avoid if the document is a .git file |
| const documentApiIssues = this._currentApiIssues[document.uri.fsPath] || [] | ||
| const documentCliIssues = this._currentCliIssues[document.uri.fsPath] || [] | ||
|
|
||
| // remove API issues found in the CLI issues |
There was a problem hiding this comment.
so basically we are prioritizing CLI issues, correct?
There was a problem hiding this comment.
yup, those should be more up to date
|
Can't approve but looks good Ale :D |
No description provided.