Conversation
Collaborator
There was a problem hiding this comment.
The code looks good, and it works great! However, I think it would be much more usable if we had a two other commands:
- List dumps that exist in the backups directory
- Load an existing backup dump by name
It's not necessarily difficult to use, but it requires the usage of the minio client which CAN be irritating to set up.
Also, thank you for building this 🙏.
…(Everything private by default)
Contributor
Author
|
I added the commands... Also made everything private by default .. but all current EDIT: Merged in conflicts, looks like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ mention of reviewers
@gibsonbailey
Resolves #139
A checklist for hand testing
./bin/pg_dump.shworks local, saves file to minio private storage/backupsdir./manage.py list_backups <search>./manage.py download_backup <dump name from above search>./bin/pg_restore.sh <dump name from download>Checklist