Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Oct 6, 2024

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Now users can select custom time for phase start and end in UTC+0 time. This can be done from both the yaml file and the editor

Screenshots

You can mention the start and end time in your yaml like this (in 24hrs format and UTC+0 timezone)
Screenshot 2024-10-07 at 10 01 53 AM

When you upload the bundle with this yaml file, you will see the phase dates in your time zone (my zone UTC+5)
Screenshot 2024-10-07 at 10 04 06 AM

Adding new phase in the editor (empty form)
Screenshot 2024-10-07 at 10 14 04 AM

Adding new phase in the editor (filled form)
Screenshot 2024-10-07 at 10 14 48 AM

Edit phase form
Screenshot 2024-10-07 at 10 16 19 AM

Documentation

Documentation updated here: https://github.com/codalab/codabench/wiki/Yaml-Structure#phases

Issues this PR resolves

A checklist for hand testing

  • Upload a version-2 bundle without time (only dates) for phases and check that phase date-time is correct (default time used 00:00)
  • Upload a version-2 bundle with time for phases and check that phase date-time is correct
  • Use competition UI to add a phase with different date-times and check that everything makes sense

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

Rebase phase_start_end_time
@Didayolo Didayolo merged commit f78bf2f into develop Nov 18, 2024
@Didayolo Didayolo deleted the phase_start_end_time branch November 18, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phase end time is not changeable Changing the start/end time of a Challenge

3 participants