Skip to content

Conversation

@ihsaan-ullah
Copy link
Collaborator

@ihsaan-ullah ihsaan-ullah commented Feb 4, 2025

@ mention of reviewers

@Didayolo

A brief description of the purpose of the changes contained in this PR.

Delete user flow is updated:

  • Add the username and email in a new table DeletedUser when a user requests deletion of his acocunt
  • During Sign up, check that the email entered is not in DeletedUser otherwise show an error
Screenshot 2025-02-04 at 12 46 27 PM
  • Django admin shows the deleted users
Screenshot 2025-02-04 at 12 51 15 PM
  • A function runs every 24 hours and deletes records from DeletedUser that are more than 30 days old

Checklist

  • Code review by me
  • Hand tested by me
  • I'm proud of my work
  • Code review by reviewer
  • Hand tested by reviewer
  • CircleCi tests are passing
  • Ready to merge

@Didayolo Didayolo self-assigned this Feb 4, 2025
@Didayolo
Copy link
Member

Didayolo commented Feb 4, 2025

Thank you for your efficiency! I'll review it as soon as possible

@Didayolo
Copy link
Member

Didayolo commented Feb 4, 2025

@ihsaan-ullah I am not able to delete an account locally. Do we need to test this on the test server?

accounts/delete/Ng/6sg-23ec25e10a3814d20b9a">http://example.com/accounts/delete/Ng/6sg-23ec25e10a3814d20b9

I get this error even when I replace example.com by localhost on the deletion link.

@ihsaan-ullah
Copy link
Collaborator Author

Deletion was working on my side locally. I had to fetch the deletion link from django logs like accounts/delete/Ng/6sg-23ec25e10a3814d20b9a

What is the error you are getting?

@Didayolo
Copy link
Member

Didayolo commented Feb 4, 2025

For some reason, now that I tried again, it worked!

@Didayolo
Copy link
Member

Didayolo commented Feb 4, 2025

OK, I tested and it is working fine. I cheated on the time delta to be able to test the removal without waiting 30 days.

@Didayolo Didayolo merged commit 660ab31 into develop Feb 4, 2025
1 check passed
@Didayolo Didayolo deleted the account_deletion_updates branch February 4, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants