OIDC updates from #2183 - Ensure username for OIDC accounts fit into db constraints#2376
Open
ihsaan-ullah wants to merge 4 commits into
Open
OIDC updates from #2183 - Ensure username for OIDC accounts fit into db constraints#2376ihsaan-ullah wants to merge 4 commits into
ihsaan-ullah wants to merge 4 commits into
Conversation
The username column is constrained to 50 characters. It's possible that a nickname or email derived username could be larger than this ( was in the case of Globus auth ). Truncate username to the 50 character limit.
Ensure username for OIDC accounts fit into db constraints
Collaborator
Author
|
Tested. This works well. @Didayolo I cannot approve this because I am the author of this PR. I let you approve and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR originates from #2183 by Chris.
Checklist