Rust Renderer: add clippy ignore for arithmetic#514
Merged
lorisleiva merged 2 commits intocodama-idl:mainfrom Mar 18, 2025
Merged
Rust Renderer: add clippy ignore for arithmetic#514lorisleiva merged 2 commits intocodama-idl:mainfrom
lorisleiva merged 2 commits intocodama-idl:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 3539f17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If you use a Codama-generated client in a library, and you try to lint that library with a
+nightlytoolchain, it will throw an error. Clippy looks through the dependencies as well, and it will barf on these "arithmetic side effects" issues.Summary of Changes
Simply add
#[allow(clippy::arithmetic_side_effects)]to the list of preexisting clippy ignores on these methods.