fix: fixes bug where empty maps could not be deserialized#4
Closed
ragboyjr wants to merge 2 commits intocodanbaru:masterfrom
Closed
fix: fixes bug where empty maps could not be deserialized#4ragboyjr wants to merge 2 commits intocodanbaru:masterfrom
ragboyjr wants to merge 2 commits intocodanbaru:masterfrom
Conversation
ragboyjr
commented
Oct 28, 2025
|
|
||
| private var currentIndex = 0 | ||
| override fun decodeElementIndex(descriptor: SerialDescriptor): Int { | ||
| if (currentIndex >= descriptor.elementsCount) return CompositeDecoder.DECODE_DONE |
Author
There was a problem hiding this comment.
this logic only works when kind is a CLASS. if a map type, elements count is always 2 which refers to the types.
- fixed issue where empty maps couldn't be decoded properly - fixed issue where decoding maps with more than 2 values would just skip everything after first entry - added support to encode maps by keys instead of by numbers
ragboyjr
force-pushed
the
fix-empty-map-decoding
branch
from
16be98a to
b647ce4
Compare
ragboyjr
force-pushed
the
fix-empty-map-decoding
branch
from
8f25001 to
9374855
Compare
Author
|
friendly bump :) |
Author
|
https://github.com/ragboyjr/dynamap/releases/tag/v0.10.0 - ended up creating a fork, upgrading the tooling and added this feature in as well This is published under |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes several issues related to maps being encoded/decoded.