Fixed the remaining duration time bug.#2941
Merged
ImprovedTube merged 1 commit intocode-charity:masterfrom May 17, 2025
Merged
Conversation
wbalbo
changed the title
Member
|
This code is for (visual) feedback when switching off the JS features: https://github.com/code-charity/youtube/blob/fb9d22e5dd8a45236b512b6b0956124a4bc2bb28/js%26css/web-accessible/core.js#L413-L415 |
|
Thank you very much @wbalbo ! I hope it can be rolled out soon. I had noticed this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve the issues #2925, and #2935
Tested on both Edge and Chrome.
The change was literally adding a span inside the ytp-time-display class element, but also an important part was the code at the top of the function, which hides the div responsible for showing the "normal" duration time of the videos.
Once the toggle is off, this div should show normally as expected.
If the toggle is on and you change it to off, the changes will not affect the actual video in real time, and for this, a refresh on the page is necessary. I tried to solve this using CSS manipulation, but I got too many issues that were not worth the effort.