Fix: Prevent duplicate player buttons on video navigation -Added uniq…#3268
Merged
ImprovedTube merged 1 commit intocode-charity:masterfrom Dec 6, 2025
Merged
Conversation
…ue IDs to all player buttons (Loop, PiP, Screenshot, Key Scene, Copy Video ID) -Changed duplicate check to search entire document instead of just section -Fixed issue code-charity#3267 where buttons duplicated when navigating between videos Each button now checks if it already exists globally before creation.
Contributor
|
Thanks for the fix! @tylerking999 Could you please attach a screenshot or short GIF showing the button behavior before and after your change? That’ll help confirm everything looks and works correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3267 - Duplicate player buttons appearing when navigating between videos
Changes Made
Technical Details
The issue occurred because
section.querySelector('.improvedtube-player-button')only searched within the sectionelement. When YouTube's SPA recreated the section during navigation, the old buttons persisted outside the new
section, causing duplicates.
Solution: Check for existing buttons at the document level using unique IDs instead of class-based section
queries.
Testing
Test plan