Fix/hamburger menu 3295#3296
Merged
ImprovedTube merged 3 commits intocode-charity:masterfrom Oct 23, 2025
Merged
Conversation
Refactors the hamburger menu logic in the video player to be more robust and readable. The previous implementation had confusing logic for toggling the visibility of the controls. The new implementation: - Simplifies the click handler logic. - Explicitly sets the initial state of the controls. - Adds a z-index to the hamburger menu to prevent it from being overlapped by other player elements. Fixes code-charity#3295
This reverts commit 83e3a2c.
This reverts commit 887ff3f.
Member
|
thank you! @ktej721 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactors the hamburger menu logic in the video player to be more readable. the previous implementation had confusing logic for toggling the visibility of the controls.
So the changes made:
Simplified the click handler logic and
explicitly set the initial state of the controls
added a z-index to the hamburger menu to prevent it from being overlapped by other player elements.
Fixes #3295
i have already tested it and it works fine.... 👍