Modified player button to be more similar to YouTube's style#3350
Closed
matteo-moro wants to merge 1 commit intocode-charity:masterfrom
Closed
Modified player button to be more similar to YouTube's style#3350matteo-moro wants to merge 1 commit intocode-charity:masterfrom
matteo-moro wants to merge 1 commit intocode-charity:masterfrom
Conversation
referring to #3347 and based on #3348 , modified the background color to be the same used in YouTube's current theme and changed width and height values + margin to make it the same as other buttons in the player. The style still doesnt exactly match YouTube's and I don't have the knowledge to know why, but it should still be an improvement
Author
|
i am genuinely not sure of why this still appears different from youtube's own style, i am guessing some other style options in other parts of the code but i am not sure where i would find those options. |
Author
|
closing since fixes to #3348 made this redundant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
referring to #3347 and based on #3348 , modified the background color to be the same used in YouTube's current theme and changed width and height values + margin to make it the same as other buttons in the player. The style still doesnt exactly match YouTube's and I don't have the knowledge to know why, but it should still be an improvement