Fix custom theme not applying after YouTube CSS changes#3791
Merged
ImprovedTube merged 1 commit intocode-charity:masterfrom Apr 16, 2026
Merged
Fix custom theme not applying after YouTube CSS changes#3791ImprovedTube merged 1 commit intocode-charity:masterfrom
ImprovedTube merged 1 commit intocode-charity:masterfrom
Conversation
Member
|
Thank you! @veerlakshay |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3784
Custom theme was using
html, [dark]as its CSS selector, which allowed YouTube's own stylesheets to override the custom CSS variables. Changed tohtml[it-theme=custom], html[it-theme=custom] [dark]for higher specificity and proper scoping.Also scoped the masthead
background-colorrule tohtml[it-theme=custom], and moved the injected<style>fromdocument.documentElementtodocument.head.Root cause: All other themes (black, plain, night, etc.) use static extension CSS in
styles.csswithhtml[it-theme=X]selectors. Custom theme was the only one relying entirely on a JS-injected<style>with the broadhtml, [dark]selector — making it vulnerable to being overridden by YouTube's own stylesheets.