Added archived field to Task model#1019
Merged
joshsmith merged 1 commit intocode-corps:developfrom Oct 8, 2017
Merged
Conversation
Contributor
|
Hey @vishaldeepak I know this wasn't in the task, but can you add this to the |
joshsmith
requested changes
Oct 6, 2017
Contributor
joshsmith
left a comment
joshsmith
left a comment
There was a problem hiding this comment.
Quick change, and see comment above.
| struct | ||
| |> changeset(params) | ||
| |> cast(params, [:status]) | ||
| |> cast(params, [:status, :archived]) |
Contributor
There was a problem hiding this comment.
Can you reorder this to be in alpha order?
| %{archived: archived} = changeset.changes | ||
| assert changeset.valid? | ||
| assert archived | ||
| end |
vishaldeepak
force-pushed
the
1006-add-archieived-to-task
branch
2 times, most recently
from
b4ced41 to
df742d4
Compare
Contributor
Author
|
Made changes accordingly |
joshsmith
force-pushed
the
1006-add-archieived-to-task
branch
from
df742d4 to
ab28deb
Compare
joshsmith
previously approved these changes
Oct 8, 2017
joshsmith
force-pushed
the
1006-add-archieived-to-task
branch
from
ab28deb to
2cc067f
Compare
joshsmith
previously approved these changes
Oct 8, 2017
joshsmith
force-pushed
the
1006-add-archieived-to-task
branch
from
2cc067f to
491e218
Compare
joshsmith
approved these changes
Oct 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Added Archived field to Tasks
Fixes #1006