Merged
Conversation
Contributor
Author
|
@landongrindheim would love to hear your thoughts on this as a quick fix, knowing that we do need to find a better longer-term solution, but with an emphasis on overcoming this quickly to reprioritize other things. |
begedin
approved these changes
Oct 9, 2017
Contributor
begedin
left a comment
begedin
left a comment
There was a problem hiding this comment.
Seems fine for now. If this makes the tests pass, I say go for it.
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This is a quick fix for the issue presented in #1027.
I know that simply killing the processes without explicitly calling
wait_for_supervisoris a bit hacky, and it requires some explicit knowledge of implicit async event processing happening, but for now it's the best quick fix I could identify to move forward.References
Fixes #1027