Skip to content

Add update action to /github-events endpoint#1206

Merged
joshsmith merged 3 commits intodevelopfrom
1168-add-update-to-github-events-endpoint
Nov 17, 2017
Merged

Add update action to /github-events endpoint#1206
joshsmith merged 3 commits intodevelopfrom
1168-add-update-to-github-events-endpoint

Conversation

@joshsmith
Copy link
Copy Markdown
Contributor

@joshsmith joshsmith commented Nov 17, 2017

What's in this PR?

  • adds validation of retry param when updating
  • adds update_changeset to the event
  • adds inclusion validation of the various statuses
  • adds update policy
  • adds update action to the controller
  • adds tests for all of the above

References

Fixes #1168

@joshsmith
Copy link
Copy Markdown
Contributor Author

This needs some tests for the webhook handler for the cases where the event already exists and needs to be reprocessed.

@joshsmith joshsmith requested a review from begedin November 17, 2017 06:00
Copy link
Copy Markdown
Contributor

@begedin begedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but my comment from the ember PR stands. This is an update action, but the user is not really patching a record. They're requesting performance of a non-RESTful action from the system.

@joshsmith joshsmith merged commit 4ee8fbe into develop Nov 17, 2017
@joshsmith joshsmith deleted the 1168-add-update-to-github-events-endpoint branch November 17, 2017 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants