Skip to content

Cleanup formatting & error handling in various stripe services#629

Merged
begedin merged 1 commit intodevelopfrom
cleanup-formatting-and-error-handling-in-stripe-services
Jan 12, 2017
Merged

Cleanup formatting & error handling in various stripe services#629
begedin merged 1 commit intodevelopfrom
cleanup-formatting-and-error-handling-in-stripe-services

Conversation

@begedin
Copy link
Copy Markdown
Contributor

@begedin begedin commented Jan 12, 2017

What's in this PR?

Cleans up formatting and error handling in our StripeService.xService modules

Mostly what's done here is

  • replaced some inline comments with actual @doc blocks
  • removed all error handling that takes in a specific value type and returns it unchanged
  • removed all _ -> {:error, :unhandled} statements, since this basically swallows error information and makes sentry useless for these cases
  • added failure -> failure to all else blocks, so sentry can catch and log them at controller level.
  • Got rid of vertically aligned formatting in the few modules that use it.

@begedin begedin merged commit 06ffc7d into develop Jan 12, 2017
@begedin begedin deleted the cleanup-formatting-and-error-handling-in-stripe-services branch January 12, 2017 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants