Fixed and simplified seeds script #773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This issue has been a common pattern recently, so this PR is an attempt to alleviate it.
In this specific case, adding the constraint that a project's long description needs to be present for the project to be approved broke the seeds script. I fixed that, but then I also made an attempt to make the seeds as simple as possible, as well as more standards compliant.
Changes
condclause with acaseclause. I believe even credo will warn us against usingcondin cases where there are less than 3 conditions, one of which istrue. Those cases are made for acasestatement. It also makes it so that the primary condition is not a negative ([]instead of![]) which is easier to read.Ecto.Changeset.merge(a negligible speed-up, but technically the more correct way to do it.Advantages
Disadvantages
TaskListmodule). I believe this is still worth it. That definition will rarely be changed.