Update designs of project page to be responsive #1049
Conversation
joshsmith
force-pushed
the
update-designs-of-project-page
branch
from
6a6c987 to
b27d55b
Compare
| margin-right: $margin-right; | ||
| width: $width; | ||
|
|
||
| &nth-child(#{$number}n) { |
There was a problem hiding this comment.
Is the last n here the placeholder that was supposed to be taken out?
There was a problem hiding this comment.
No this is the _x_n-th item we want that to happen on. That means it repeats.
|
|
||
| .project-main { | ||
| @include span-columns(8); | ||
| @include media($lg-screen) { |
There was a problem hiding this comment.
Just for my knowledge, where does the media($lg-screen) come into play? I see from the _breakpoints.scss its defining sizes but how does it recognize/render this?
There was a problem hiding this comment.
Just normal media breakpoints. Browser behavior comes into play here.
| @@ -1,10 +1,4 @@ | |||
| .project-long-description { | |||
There was a problem hiding this comment.
Also remove the class in the component js file?
There was a problem hiding this comment.
I didn't remove that because I like to keep the component 1-1 with classes, even if it doesn't have styling.
|
|
||
| {{project-long-description project=project}} | ||
| <div class="project-main"> | ||
| {{project-long-description project=project}} |
There was a problem hiding this comment.
Include this tag and class in the component js?
There was a problem hiding this comment.
There may be more things that go into the main area.
There was a problem hiding this comment.
See the sidebar below to see what I mean.
joshsmith
force-pushed
the
update-designs-of-project-page
branch
from
b27d55b to
1884764
Compare
begedin
left a comment
begedin
left a comment
There was a problem hiding this comment.
Not much to say about this from me, other than that it looks good.
joshsmith
force-pushed
the
update-designs-of-project-page
branch
from
1884764 to
7343508
Compare
What's in this PR?
Brings in some changes to the project and the sidebar.