Fix issues with submittable-textarea, refactor/add page objects #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begedin
force-pushed
the
fix-submittable-textarea
branch
from
5c53bbd to
483d2c6
Compare
Contributor
|
Ah I spent a ton of time on this and you figured it out! 🎩 s off to you! |
joshsmith
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Cherry-picked from #1077
This fixes tests for editor-with-preview and submittable-textarea on my machine, but, apparently, breaks them on CI.
It also makes the page objects a bit nicer and introduces a submittable-textarea page object.
I think it's worth figuring out and fixing, but I did not want to block the merge of #1077 so I cherry picked into a separate PR.