Add error-formatter component to parse and display adapter errors #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #85 and possibly #28 and #29
The phantomjs installation ember-cli includes in its locally installed npm package somehow got corrupted on my end, causing the browser to crash while running tests.
To get around it, I deleted the
node_modulesfolder and re-rannpm install. I'm guessing some components got updated this way, due to how we specify our versions, so as a result, the default message anAdapterErrorcontains changed, causing tests to fail.Since we already talked about formatting errors such as that one in a nicer way, I decided to quickly implement an error formatter component, to use in place of these basic errors.
An adapter error looks like something along the lines of
For each error in the errors array, the component will output a
I think that's sufficient for now, but we will be able to modify this behavior as we please in the future.