Skip to content

Refactor skill lists #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2017
Merged

Refactor skill lists #1167

merged 1 commit into from
Mar 18, 2017

Conversation

@joshsmith
Copy link
Contributor

@joshsmith joshsmith commented Mar 18, 2017

What's in this PR?

Does some refactoring of skills lists:

  • Makes it so that skill-list-item renders the skill-list-item-link only when authenticated and isClickable is explicitly defined
  • Breaks out styling for a span that's not clickable from an a that is
  • Removes the skills-list component in favor of related-skills

@joshsmith joshsmith force-pushed the refactor-skill-lists branch from e1d97b9 to 8904419 Compare March 18, 2017 21:18
@joshsmith joshsmith force-pushed the refactor-skill-lists branch from 8904419 to 91db01f Compare March 18, 2017 21:44
@joshsmith joshsmith merged commit c145dce into develop Mar 18, 2017
@joshsmith joshsmith deleted the refactor-skill-lists branch March 18, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@begedin begedin begedin approved these changes

Assignees

No one assigned

Labels

ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshsmith @begedin