Add GitHub pull requests #1431
Merged
Add GitHub pull requests #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This needs a test for the |
joshsmith
force-pushed
the
add-github-pull-requests
branch
from
b01050b to
9178b23
Compare
joshsmith
force-pushed
the
add-github-pull-requests
branch
from
9178b23 to
6521f22
Compare
begedin
requested changes
Oct 18, 2017
Contributor
begedin
left a comment
begedin
left a comment
There was a problem hiding this comment.
task-card needs a test that it renders the pull request icon. I'll add it
- pull request icon renders when there's a pull request - pull request icon does not render when there isn't a pull request
begedin
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
WIP. Adds beginning of GithubPullRequest model and icons, and other UI changes.Edited before final merge
This PR
GithubPullRequestmodelpull-request-iconcomponent, which renders a closed/merged statetask-cardcomponent if the task is associated to a pull request